Skip to content

RTC and CAN shell completion #79251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

RTC and CAN shell completion #79251

wants to merge 2 commits into from

Conversation

yishai1999
Copy link
Contributor

Trying to improve the shell commands completion

@yishai1999
rtc_shell: autocomplete only rtc devices
b1ede94 
This commit makes it so the rtc shell command only tab completes with
actual RTC devices instead of all devices.

Signed-off-by: Yishai Jaffe <[email protected]>
@yishai1999
can_shell: autocomplete only can devices
7d8394c 
This commit makes it so the can shell commands only tab completes with
actual CAN devices instead of all devices.

Signed-off-by: Yishai Jaffe <[email protected]>
@zephyrbot zephyrbot added area: CAN area: RTC Real Time Clock labels Oct 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 1, 2024

Hello @yishai1999, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

henrikbrixandersen
henrikbrixandersen requested changes Oct 1, 2024
View reviewed changes
Copy link
Member

@henrikbrixandersen henrikbrixandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Limiting the device selection/completion to in-tree compatibles is not an option, sorry.

This needs to solved on a higher level, which is being worked on.

@yishai1999
Copy link
Contributor Author

@henrikbrixandersen I saw this is what's done in the ADC shell. How come it's not an option here? At least until a wider solution is found...

@henrikbrixandersen
Copy link
Member

@henrikbrixandersen I saw this is what's done in the ADC shell. How come it's not an option here? At least until a wider solution is found...

Correct, but we are actively working on getting rid of that (see #67698 and #71773). There is no point in introducing more technical dept in this area.

@bjarki-andreasen
Copy link
Contributor

Just to concur, the solutions in #67698 and #71773 are quite promising and scalable, work on these or in similar direction would be highly appreciated :)

@kartben
Copy link
Contributor

kartben commented Nov 18, 2024

as per earlier comments, will close this one given recommended approach is being discussed in other PRs. @yishai1999 please do feel free to chime in there if you haven't already as I hope you will find other way to contribute than this current PR! :)

@kartben kartben closed this Nov 18, 2024
@yishai1999 yishai1999 deleted the rtc_and_can_shell_completion branch November 28, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrikbrixandersen henrikbrixandersen henrikbrixandersen requested changes

@alexanderwachter alexanderwachter Awaiting requested review from alexanderwachter

@bjarki-andreasen bjarki-andreasen Awaiting requested review from bjarki-andreasen

@martinjaeger martinjaeger Awaiting requested review from martinjaeger

@str4t0m str4t0m Awaiting requested review from str4t0m

Assignees

@henrikbrixandersen henrikbrixandersen

Labels
area: CAN area: RTC Real Time Clock
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yishai1999 @henrikbrixandersen @bjarki-andreasen @kartben @zephyrbot